Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue 297: Update format of the report scores #301

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

issue 297: Update format of the report scores #301

wants to merge 1 commit into from

Conversation

Nordine67200
Copy link

feature 297

@Nordine67200 Nordine67200 requested a review from a team as a code owner February 2, 2023 16:29
@Nordine67200 Nordine67200 requested review from pvk-developer and removed request for a team February 2, 2023 16:29
@CLAassistant
Copy link

CLAassistant commented Feb 2, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@npatki
Copy link
Contributor

npatki commented Mar 13, 2023

Hi @Nordine67200, thanks for contributing to the SDV codebase. We are in the process of deprecating our old, CLA assistant bot (seen up above) and moving over to a new Contributor Licensing Agreement.

To request our new Contributor Licensing Agreement, we ask that you please fill out the information in the form: https://bit.ly/sdv-cla-form. Once we receive your submission, we'll send you a PDF to the email that you give us.

You will only have to do this once for contributing to any of the libraries in the SDV ecosystem. Thanks for bearing with us!

@npatki npatki added the PR:CLA Approved The required CLA has been signed label Mar 14, 2023
@npatki
Copy link
Contributor

npatki commented Mar 14, 2023

Thanks for signing the CLA @Nordine67200. A member of the SDV team can will review your code and get back to you.

@amontanez24 amontanez24 requested review from amontanez24 and removed request for pvk-developer June 13, 2023 17:39
amontanez24
amontanez24 approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amontanez24 amontanez24 amontanez24 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
PR:CLA Approved The required CLA has been signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Nordine67200 @CLAassistant @npatki @amontanez24